feat(rpc): add impls for gasprice and max priority fee #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/add-price-impl
branch
from
d270c85 to
81d225e
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2471 +/- ##
==========================================
+ Coverage 71.62% 71.67% +0.05%
==========================================
Files 487 487
Lines 60520 60550 +30
==========================================
+ Hits 43346 43401 +55
+ Misses 17174 17149 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gakonst
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2470
🤖 Generated by Copilot at d270c85
This pull request adds support for the EIP-1559 fee market and dynamic fee transactions to the RPC API, and refactors some of the block-related methods and types. It introduces a new
eth_maxPriorityFeePerGasRPC method, and implements thegas_priceandsuggested_priority_feemethods for theEthFeesApitrait. It also splits theblockmethod of theEthApitrait intoheaderandblock, and adds arpc_blockmethod that returns a full RPC block object. Additionally, it implements theFrom<SealedBlock>trait for theBlocktype, which simplifies the conversion of blocks from different sources.adds impl of
eth_gasPrice, ref: https://github.com/ethereum/go-ethereum/blob/8f373227ac481685148019b21ef9e1478d3ba609/internal/ethapi/api.go#L62-L72and a shim for
max priority feewhich is implemented herehttps://github.com/ethereum/go-ethereum/blob/8f373227ac481685148019b21ef9e1478d3ba609/eth/gasprice/gasprice.go#L144-L150
ref ethereum/pm#328 (comment)